Skip to content

Allow usage of ColorConverter with Bitmap saving #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2024
Merged

Allow usage of ColorConverter with Bitmap saving #34

merged 2 commits into from
Feb 20, 2024

Conversation

@FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Feb 20, 2024

This change lets you use this library to save Bitmap objects that were created with jpegio.JpegDecoder or adafruit_imageload

This was referenced Feb 20, 2024
Closed
Merged
@FoamyGuy FoamyGuy requested a review from a team February 20, 2024 17:02
tannewt
tannewt approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@tannewt tannewt merged commit 36c2447 into adafruit:main Feb 20, 2024
@FoamyGuy FoamyGuy mentioned this pull request Feb 22, 2024
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 23, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@38b61d2)
d7d3718 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.3.0 from 1.2.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#34 from FoamyGuy/support_colorconverter

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyCamera to 1.1.0 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#28 from FoamyGuy/overlays
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#30 from adafruit/ipcam-was-unuseful-name

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannewt tannewt tannewt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FoamyGuy @tannewt